lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 275/312] bnxt_en: Remove locking around txr->dev_state
    Date
    From: Florian Fainelli <f.fainelli@gmail.com>

    commit cbce91cad4ee39070bf3c7873767194e4be88e16 upstream.

    txr->dev_state was not consistently manipulated with the acquisition of
    the per-queue lock, after further inspection the lock does not seem
    necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0.

    Reported-by: coverity (CID 1339583)
    Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Acked-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    @@ -4310,9 +4310,7 @@ static void bnxt_tx_disable(struct bnxt
    bnapi = bp->bnapi[i];
    txr = &bnapi->tx_ring;
    txq = netdev_get_tx_queue(bp->dev, i);
    - __netif_tx_lock(txq, smp_processor_id());
    txr->dev_state = BNXT_DEV_STATE_CLOSING;
    - __netif_tx_unlock(txq);
    }
    }
    /* Stop all TX queues */

    \
     
     \ /
      Last update: 2020-05-08 15:06    [W:2.369 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site