lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 07/49] ASoC: topology: Check return value of pcm_new_ver
    Date
    From: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>

    [ Upstream commit b3677fc3d68dd942c92de52f0bd9dd8b472a40e6 ]

    Function pcm_new_ver can fail, so we should check it's return value and
    handle possible error.

    Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
    Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
    Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Link: https://lore.kernel.org/r/20200327204729.397-6-amadeuszx.slawinski@linux.intel.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/soc-topology.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
    index aa7714f2b78fd..ca0ac5372b293 100644
    --- a/sound/soc/soc-topology.c
    +++ b/sound/soc/soc-topology.c
    @@ -2135,7 +2135,9 @@ static int soc_tplg_pcm_elems_load(struct soc_tplg *tplg,
    _pcm = pcm;
    } else {
    abi_match = false;
    - pcm_new_ver(tplg, pcm, &_pcm);
    + ret = pcm_new_ver(tplg, pcm, &_pcm);
    + if (ret < 0)
    + return ret;
    }

    /* create the FE DAIs and DAI links */
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-05-08 14:58    [W:4.068 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site