lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/5] iio: accel: Add bma023 support to bma180
On Wed, 6 May 2020 20:49:17 -0700
Jonathan Bakker <xc-racer2@live.ca> wrote:

> Hi Linus,
>
> On 2020-05-06 5:47 a.m., Linus Walleij wrote:
> > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker <xc-racer2@live.ca> wrote:
> >
> >> This patchset adds support for the bma023 three axis accelerometer
> >> to the bma180 IIO driver. The bma023 is found on several ~2010
> >> phones, including the first-gen Galaxy S series.
> >>
> >> The bma023 differs from later chips (bma180, bma25x) in that it
> >> has no low power but still working mode and no temperature
> >> channel.
> >>
> >> The bma023 is already supported by a misc input driver (bma150), so
> >> when both are enabled, the iio driver is preferred. The bma150
> >> is very similar to the bma023, but has a temperature channel.
> >> Support for the bma150 is not added in this patchset.
> >
> > I'd say, if it's not too much trouble please also patch in
> > support for BMA150 and SMB380 to the IIO driver so
> > we can delete this old Input driver, we have done this
> > before and thes "input drivers" are just causing headaches
> > and wasting time for the Input maintainer.
> >
>
> Looking at the bma150, it looks the same. The temperature is implemented
> slightly differently than on the bma180+ (unsigned vs signed) but should
> be quite easy to add. I'll add a new patch for it in v2.

Great. Series looks fine to me as well, so should be fine to apply v2.
(subject to Dmitry Ack).

Jonathan

>
> > It can be in a separate patch set from this one if you
> > don't want to get stuck on this.
> >
> > Yours,
> > Linus Walleij
> >
>
> Thanks,
> Jonathan


\
 
 \ /
  Last update: 2020-05-08 14:48    [W:0.056 / U:0.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site