lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 134/312] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit d16a2b9f2465b5486f830178fbfb7d203e0a17ae upstream.

    "data" is always NULL in this function. I think we should be passing
    "&data" to sst_prepare_and_post_msg() instead of "data".

    Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Tested-by: Dinesh Mirche <dinesh.mirche@intel.com>
    Acked-by: Vinod Koul <vinod.koul@intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/soc/intel/atom/sst/sst_stream.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/soc/intel/atom/sst/sst_stream.c
    +++ b/sound/soc/intel/atom/sst/sst_stream.c
    @@ -108,7 +108,7 @@ int sst_alloc_stream_mrfld(struct intel_
    str_id, pipe_id);
    ret = sst_prepare_and_post_msg(sst_drv_ctx, task_id, IPC_CMD,
    IPC_IA_ALLOC_STREAM_MRFLD, pipe_id, sizeof(alloc_param),
    - &alloc_param, data, true, true, false, true);
    + &alloc_param, &data, true, true, false, true);

    if (ret < 0) {
    dev_err(sst_drv_ctx->dev, "FW alloc failed ret %d\n", ret);

    \
     
     \ /
      Last update: 2020-05-08 14:42    [W:2.729 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site