Messages in this thread | | | Date | Fri, 8 May 2020 10:44:26 +0200 | From | Peter Zijlstra <> | Subject | Re: [patch V4 part 1 24/36] lockdep: Prepare for noinstr sections |
| |
On Thu, May 07, 2020 at 08:23:39PM -0400, Steven Rostedt wrote:
> > +void lockdep_hardirqs_on_prepare(unsigned long ip)
> > +void noinstr lockdep_hardirqs_on(unsigned long ip)
> Would be nice to have some kerneldoc explaining the difference between > lockdep_hardirqs_on_prepare() and lockdep_hardirqs_on().
As the naming suggests, it's not a matter of difference, but of order, first you call on_prepare(), then you call on(). The function signature as per the above gives clue why.
| |