lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net/sonic: Fix some resource leaks in error handling paths

On Fri, 8 May 2020, Jakub Kicinski wrote:

> On Fri, 8 May 2020 19:25:57 +0200 Christophe JAILLET wrote:
> > Only macsonic has been compile tested. I don't have the needed setup to
> > compile xtsonic
>
> Well, we gotta do that before we apply the patch :S
>

I've compiled xtsonic.c with this patch.

> Does the driver actually depend on some platform stuff,

xtsonic.c looks portable enough but it has some asm includes that I
haven't looked at. It is really a question for the arch maintainers.

> or can we do this:
>
> diff --git a/drivers/net/ethernet/natsemi/Kconfig b/drivers/net/ethernet/natsemi/Kconfig
> @@ -58,7 +58,7 @@ config NS83820
>
> config XTENSA_XT2000_SONIC
> tristate "Xtensa XT2000 onboard SONIC Ethernet support"
> - depends on XTENSA_PLATFORM_XT2000
> + depends on XTENSA_PLATFORM_XT2000 || COMPILE_TEST
> ---help---
> This is the driver for the onboard card of the Xtensa XT2000 board.
>
> ?
>

That's effectively what I did to compile test xtsonic.c (I removed the
line to get the same effect).

\
 
 \ /
  Last update: 2020-05-09 03:58    [W:1.057 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site