Messages in this thread | | | Date | Fri, 8 May 2020 18:54:02 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] net/sonic: Fix some resource leaks in error handling paths |
| |
On Fri, 8 May 2020 19:25:57 +0200 Christophe JAILLET wrote: > @@ -527,8 +531,9 @@ static int mac_sonic_platform_remove(struct platform_device *pdev) > struct sonic_local* lp = netdev_priv(dev); > > unregister_netdev(dev); > - dma_free_coherent(lp->device, SIZEOF_SONIC_DESC * SONIC_BUS_SCALE(lp->dma_bitmode), > - lp->descriptors, lp->descriptors_laddr); > + dma_free_coherent(lp->device, > + SIZEOF_SONIC_DESC * SONIC_BUS_SCALE(lp->dma_bitmode), > + lp->descriptors, lp->descriptors_laddr); > free_netdev(dev); > > return 0;
This is a white-space only change, right? Since this is a fix we should avoid making cleanups which are not strictly necessary.
| |