lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/4] crypto: hisilicon/zip - constify struct debugfs_reg32
From
Date
On 2020/5/9 6:35, Rikard Falkeborn wrote:
> hzip_dfx_regs is never changed and can be made const.
>
> This allows the compiler to put it in the text section instead of the
> data section.
>
> Before:
> text data bss dec hex filename
> 15236 6160 480 21876 5574 drivers/crypto/hisilicon/zip/zip_main.o
>
> After:
> text data bss dec hex filename
> 15620 5776 480 21876 5574 drivers/crypto/hisilicon/zip/zip_main.o
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>

Thanks for fixing this.

> ---
> drivers/crypto/hisilicon/zip/zip_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c
> index 37db11f96fab..6934a03d21e1 100644
> --- a/drivers/crypto/hisilicon/zip/zip_main.c
> +++ b/drivers/crypto/hisilicon/zip/zip_main.c
> @@ -165,7 +165,7 @@ static const u64 core_offsets[] = {
> [HZIP_DECOMP_CORE5] = 0x309000,
> };
>
> -static struct debugfs_reg32 hzip_dfx_regs[] = {
> +static const struct debugfs_reg32 hzip_dfx_regs[] = {
> {"HZIP_GET_BD_NUM ", 0x00ull},
> {"HZIP_GET_RIGHT_BD ", 0x04ull},
> {"HZIP_GET_ERROR_BD ", 0x08ull},
>

\
 
 \ /
  Last update: 2020-05-09 03:51    [W:0.081 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site