lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 170/312] [media] lirc_imon: do not leave imon_probe() with mutex held
    Date
    From: Alexey Khoroshilov <khoroshilov@ispras.ru>

    commit b833d0df943d70682e288c38c96b8e7bfff4023a upstream.

    Commit af8a819a2513 ("[media] lirc_imon: simplify error handling code")
    lost mutex_unlock(&context->ctx_lock), so imon_probe() exits with
    the context->ctx_lock mutex acquired.

    The patch adds mutex_unlock(&context->ctx_lock) back.

    Found by Linux Driver Verification project (linuxtesting.org).

    Fixes: af8a819a2513 ("[media] lirc_imon: simplify error handling code")

    Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/media/lirc/lirc_imon.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/staging/media/lirc/lirc_imon.c
    +++ b/drivers/staging/media/lirc/lirc_imon.c
    @@ -885,12 +885,14 @@ static int imon_probe(struct usb_interfa
    vendor, product, ifnum, usbdev->bus->busnum, usbdev->devnum);

    /* Everything went fine. Just unlock and return retval (with is 0) */
    + mutex_unlock(&context->ctx_lock);
    goto driver_unlock;

    unregister_lirc:
    lirc_unregister_driver(driver->minor);

    free_tx_urb:
    + mutex_unlock(&context->ctx_lock);
    usb_free_urb(tx_urb);

    free_rx_urb:

    \
     
     \ /
      Last update: 2020-05-08 15:19    [W:4.032 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site