lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 176/312] mfd: lp8788-irq: Uninitialized variable in irq handler
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 22aab38e7b59fd79ce1045006be69a9abab58e5a upstream.

    Instead to being true/false, the "handled" is true/uninitialized.
    Presumably this doesn't cause that many problems in real life because
    normally we handle the IRQ.

    Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Milo Kim <milo.kim@ti.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mfd/lp8788-irq.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mfd/lp8788-irq.c
    +++ b/drivers/mfd/lp8788-irq.c
    @@ -112,7 +112,7 @@ static irqreturn_t lp8788_irq_handler(in
    struct lp8788_irq_data *irqd = ptr;
    struct lp8788 *lp = irqd->lp;
    u8 status[NUM_REGS], addr, mask;
    - bool handled;
    + bool handled = false;
    int i;

    if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))

    \
     
     \ /
      Last update: 2020-05-08 15:18    [W:3.382 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site