Messages in this thread | | | Date | Fri, 8 May 2020 00:32:22 +0300 | From | Serge Semin <> | Subject | Re: [PATCH v2 04/20] mips: cm: Fix an invalid error code of INTVN_*_ERR |
| |
On Thu, May 07, 2020 at 01:10:07PM +0200, Thomas Bogendoerfer wrote: > On Wed, May 06, 2020 at 08:42:22PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > > Commit 3885c2b463f6 ("MIPS: CM: Add support for reporting CM cache > > errors") adds cm2_causes[] array with map of error type ID and > > pointers to the short description string. There is a mistake in > > the table, since according to MIPS32 manual CM2_ERROR_TYPE = {17,18} > > correspond to INTVN_WR_ERR and INTVN_RD_ERR, while the table > > claims they have {0x17,0x18} codes. This is obviously hex-dec > > copy-paste bug. Moreover codes {0x18 - 0x1a} indicate L2 ECC errors. > > > > Fixes: 3885c2b463f6 ("MIPS: CM: Add support for reporting CM cache errors") > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > Cc: Paul Burton <paulburton@kernel.org> > > Cc: Ralf Baechle <ralf@linux-mips.org> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: linux-pm@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > --- > > arch/mips/kernel/mips-cm.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > applied to mips-next.
Great! Thanks.
-Sergey
> > Thomas. > > -- > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > good idea. [ RFC1925, 2.3 ]
| |