lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 04/10] pstore: Rename "allpstore" to "records_list"
Date
The name "allpstore" doesn't carry much meaning, so rename it to what it
actually is: the list of all records present in the filesystem. The lock
is also renamed accordingly.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
fs/pstore/inode.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
index d99b5d39aa90..5cc09cb315f9 100644
--- a/fs/pstore/inode.c
+++ b/fs/pstore/inode.c
@@ -29,8 +29,8 @@

#define PSTORE_NAMELEN 64

-static DEFINE_SPINLOCK(allpstore_lock);
-static LIST_HEAD(allpstore);
+static DEFINE_SPINLOCK(records_list_lock);
+static LIST_HEAD(records_list);

struct pstore_private {
struct list_head list;
@@ -196,9 +196,9 @@ static void pstore_evict_inode(struct inode *inode)

clear_inode(inode);
if (p) {
- spin_lock_irqsave(&allpstore_lock, flags);
+ spin_lock_irqsave(&records_list_lock, flags);
list_del(&p->list);
- spin_unlock_irqrestore(&allpstore_lock, flags);
+ spin_unlock_irqrestore(&records_list_lock, flags);
free_pstore_private(p);
}
}
@@ -302,8 +302,8 @@ int pstore_mkfile(struct dentry *root, struct pstore_record *record)

WARN_ON(!inode_is_locked(d_inode(root)));

- spin_lock_irqsave(&allpstore_lock, flags);
- list_for_each_entry(pos, &allpstore, list) {
+ spin_lock_irqsave(&records_list_lock, flags);
+ list_for_each_entry(pos, &records_list, list) {
if (pos->record->type == record->type &&
pos->record->id == record->id &&
pos->record->psi == record->psi) {
@@ -311,7 +311,7 @@ int pstore_mkfile(struct dentry *root, struct pstore_record *record)
break;
}
}
- spin_unlock_irqrestore(&allpstore_lock, flags);
+ spin_unlock_irqrestore(&records_list_lock, flags);
if (rc)
return rc;

@@ -343,9 +343,9 @@ int pstore_mkfile(struct dentry *root, struct pstore_record *record)

d_add(dentry, inode);

- spin_lock_irqsave(&allpstore_lock, flags);
- list_add(&private->list, &allpstore);
- spin_unlock_irqrestore(&allpstore_lock, flags);
+ spin_lock_irqsave(&records_list_lock, flags);
+ list_add(&private->list, &records_list);
+ spin_unlock_irqrestore(&records_list_lock, flags);

return 0;

--
2.20.1
\
 
 \ /
  Last update: 2020-05-06 17:22    [W:0.080 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site