lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 4/5] net: macb: fix macb_suspend() by removing call to netif_carrier_off()
    Date
    From: Nicolas Ferre <nicolas.ferre@microchip.com>

    As we now use the phylink call to phylink_stop() in the non-WoL path,
    there is no need for this call to netif_carrier_off() anymore. It can
    disturb the underlying phylink FSM.

    Fixes: 7897b071ac3b ("net: macb: convert to phylink")
    Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
    Cc: Harini Katakam <harini.katakam@xilinx.com>
    Cc: Antoine Tenart <antoine.tenart@bootlin.com>
    ---
    Changes in v2:
    - new in v2 serries

    drivers/net/ethernet/cadence/macb_main.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
    index 24c044dc7fa0..ebc57cd5d286 100644
    --- a/drivers/net/ethernet/cadence/macb_main.c
    +++ b/drivers/net/ethernet/cadence/macb_main.c
    @@ -4562,7 +4562,6 @@ static int __maybe_unused macb_suspend(struct device *dev)
    bp->pm_data.scrt2 = gem_readl_n(bp, ETHT, SCRT2_ETHT);
    }

    - netif_carrier_off(netdev);
    if (bp->ptp_info)
    bp->ptp_info->ptp_remove(netdev);
    pm_runtime_force_suspend(dev);
    --
    2.26.2
    \
     
     \ /
      Last update: 2020-05-06 13:43    [W:3.069 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site