lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 1/9] w1_therm: creating w1_therm.h
From
Date
Le mercredi 06 mai 2020 à 08:51 +0200, Greg KH a écrit :
> > > Why is this function needed to be declared in this .h file?
> > > Why is any of this needed? For some reason I thought you needed
> > > a .h
> > > file to make things simpler for other .c files, but if all of
> > > this is
> > > static, it's not needed at all, right?
> > > thanks,
> > > greg k-h
> > Hello,
> > Yes, you are right, header file could be avoided. But we separate
> > it
> > from .c for clarity purpose, and to ease future developpment (for
> > example adding support of new devices).
> > If you absolutely want to put everything in the .c file, I can do
> > it,
> > let me know.
>
>
> Keep it all in a .c file, only use .h files for when you need to
> share
>
> it across multiple .c files, otherwise it's not needed.
>
>
>
> thanks,
>
>
>
> greg k-h

Hi,

Ok well noted, I will do it tomorrow, and keep it as 8 patches.

Thanks for your time

Akira Shimahara

\
 
 \ /
  Last update: 2020-05-06 12:44    [W:0.178 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site