Messages in this thread | | | Subject | Re: [PATCH 2/5] input: misc: bma150: Conditionally disable bma023 support | From | Jonathan Bakker <> | Date | Wed, 6 May 2020 20:46:12 -0700 |
| |
Hi Linus,
On 2020-05-06 5:46 a.m., Linus Walleij wrote: > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker <xc-racer2@live.ca> wrote: > >> The bma180 IIO driver has been extended for support for bma023. >> However, this could cause conflicts with this driver. Since some >> setups may depend upon the evdev setup, disable support in this >> driver for the bma023 only when the IIO driver is being built. >> >> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> > > I would just fix this with KConfig instead, like add mutually > exclusive depends on these two drivers. > > Set this input driver as: > depends on BMA180=n > > And the IIO driver as: > depends on INPUT_BMA150=n > > It's a rough measure but this input driver should anyway > go away. >
Ok, sounds good to me. If I include a patch removing the input driver, can I just drop this patch entirely?
The only in-tree user of the input driver (based on i2c ids) is Intel Mid. Not sure what the kernel policy on dropping drivers is.
> Yours, > Linus Walleij >
Thanks, Jonathan
| |