lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 6/6] pstore/ram: Adjust module param permissions to reflect reality
    Date
    A couple module parameters had 0600 permissions, but changing them would
    have no impact on ramoops, so switch these to 0400 to reflect reality.

    Signed-off-by: Kees Cook <keescook@chromium.org>
    ---
    fs/pstore/ram.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
    index b8dac1d04e96..1de9d68d5c24 100644
    --- a/fs/pstore/ram.c
    +++ b/fs/pstore/ram.c
    @@ -53,7 +53,7 @@ MODULE_PARM_DESC(mem_size,
    "size of reserved RAM used to store oops/panic logs");

    static unsigned int mem_type;
    -module_param(mem_type, uint, 0600);
    +module_param(mem_type, uint, 0400);
    MODULE_PARM_DESC(mem_type,
    "set to 1 to try to use unbuffered memory (default 0)");

    @@ -68,7 +68,7 @@ MODULE_PARM_DESC(max_reason,
    "maximum reason for kmsg dump (default 2: Oops and Panic) ");

    static int ramoops_ecc;
    -module_param_named(ecc, ramoops_ecc, int, 0600);
    +module_param_named(ecc, ramoops_ecc, int, 0400);
    MODULE_PARM_DESC(ramoops_ecc,
    "if non-zero, the option enables ECC support and specifies "
    "ECC buffer size in bytes (1 is a special value, means 16 "
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-05-06 23:16    [W:7.070 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site