lkml.org 
[lkml]   [2020]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v6 1/5] soc: qcom: rpmh-rsc: Correctly ignore CPU_CLUSTER_PM notifications
    From
    Date
    Quoting Douglas Anderson (2020-05-04 10:50:15)
    > Our switch statement doesn't have entries for CPU_CLUSTER_PM_ENTER,
    > CPU_CLUSTER_PM_ENTER_FAILED, and CPU_CLUSTER_PM_EXIT and doesn't have
    > a default. This means that we'll try to do a flush in those cases but
    > we won't necessarily be the last CPU down. That's not so ideal since
    > our (lack of) locking assumes we're on the last CPU.
    >
    > Luckily this isn't as big a problem as you'd think since (at least on
    > the SoC I tested) we don't get these notifications except on full
    > system suspend. ...and on full system suspend we get them on the last
    > CPU down. That means that the worst problem we hit is flushing twice.
    > Still, it's good to make it correct.
    >
    > Fixes: 985427f997b6 ("soc: qcom: rpmh: Invoke rpmh_flush() for dirty caches")
    > Reported-by: Stephen Boyd <swboyd@chromium.org>
    > Signed-off-by: Douglas Anderson <dianders@chromium.org>
    > ---

    Reviewed-by: Stephen Boyd <swboyd@chromium.org>

    \
     
     \ /
      Last update: 2020-05-05 08:32    [W:2.737 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site