Messages in this thread | | | From | Arnaldo Carvalho de Melo <> | Date | Tue, 5 May 2020 09:38:00 -0300 | Subject | Re: [PATCH v2 0/3] Improvements for kallsyms__parse |
| |
Em Fri, May 01, 2020 at 03:13:12PM -0700, Ian Rogers escreveu: > kallsyms__parse is called 4 times during perf record startup. Add a > benchmark to measure its performance. Transition it to using the api > io.h buffered reading, improving performance by ~8% or saving ~5% from > perf record start up time. > > v2. Fix the err return value for success, error reported by > jolsa@redhat.com. Add clean-up for hex2u64.
Thanks, applied. Jiri, please let me know if I can stick your Acked-by or, better, Reviewed-by there, Namhyung, others, please consider doing the same :-)
- Arnaldo
> Ian Rogers (3): > perf bench: add kallsyms parsing > lib kallsyms: parse using io api > lib kallsyms: move hex2u64 out of header > > tools/lib/api/io.h | 3 ++ > tools/lib/symbol/kallsyms.c | 86 ++++++++++++++----------------- > tools/lib/symbol/kallsyms.h | 2 - > tools/perf/bench/Build | 1 + > tools/perf/bench/bench.h | 1 + > tools/perf/bench/kallsyms-parse.c | 75 +++++++++++++++++++++++++++ > tools/perf/builtin-bench.c | 1 + > tools/perf/util/symbol.c | 14 +++++ > 8 files changed, 133 insertions(+), 50 deletions(-) > create mode 100644 tools/perf/bench/kallsyms-parse.c > > -- > 2.26.2.526.g744177e7f7-goog >
--
- Arnaldo
| |