lkml.org 
[lkml]   [2020]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] Kbuild: disable FORTIFY_SOURCE on clang-10
    On Tue, May 5, 2020 at 5:22 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
    >
    > On Tue, May 5, 2020 at 5:19 PM Kees Cook <keescook@chromium.org> wrote:
    > >
    > > On Tue, May 05, 2020 at 04:37:38PM -0600, Jason A. Donenfeld wrote:
    > > > On Tue, May 5, 2020 at 4:25 PM Nathan Chancellor
    > > > <natechancellor@gmail.com> wrote:
    > > > > I believe these issues are one in the same. I did a reverse bisect with
    > > > > Arnd's test case and converged on George's first patch:
    > > > >
    > > > > https://github.com/llvm/llvm-project/commit/2dd17ff08165e6118e70f00e22b2c36d2d4e0a9a
    > > > >
    > > > > I think that in lieu of this patch, we should have that patch and its
    > > > > follow-up fix merged into 10.0.1.
    > > >
    > > > If this is fixed in 10.0.1, do we even need to patch the kernel at
    > > > all? Or can we just leave it be, considering most organizations using
    > > > clang know what they're getting into? I'd personally prefer the
    > > > latter, so that we don't clutter things.
    > >
    > > I agree: I'd rather this was fixed in 10.0.1 (but if we do want a
    > > kernel-side work-around for 10.0.0, I would suggest doing the version
    > > check in the Kconfig for FORTIFY_SOURCE instead of in the Makefile,
    > > as that's where these things are supposed to live these days).
    >
    > Indeed this belongs in the Makefile. I can send a patch adjusting

    er, Kconfig, is what I meant to type.

    \
     
     \ /
      Last update: 2020-05-06 01:23    [W:2.280 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site