Messages in this thread | | | Subject | Re: [PATCH 0/4] eliminate SECTOR related magic numbers and duplicated conversions | From | antlists <> | Date | Tue, 5 May 2020 18:32:36 +0100 |
| |
On 05/05/2020 12:55, Zhen Lei wrote: > When I studied the code of mm/swap, I found "1 << (PAGE_SHIFT - 9)" appears > many times. So I try to clean up it. > > 1. Replace "1 << (PAGE_SHIFT - 9)" or similar with SECTORS_PER_PAGE > 2. Replace "PAGE_SHIFT - 9" with SECTORS_PER_PAGE_SHIFT > 3. Replace "9" with SECTOR_SHIFT > 4. Replace "512" with SECTOR_SIZE
Naive question - what is happening about 4096-byte sectors? Do we need to forward-plan?
Cheers, Wol
| |