lkml.org 
[lkml]   [2020]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] selftests/vm/keys: fix a broken reference at protection_keys.c
    From
    Date
    On 5/4/20 2:44 AM, Mauro Carvalho Chehab wrote:
    > Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api book")
    > from Jun 7, 2019 converted protection-keys.txt file to ReST.
    >
    > A recent change at protection_keys.c partially reverted such
    > changeset, causing it to point to a non-existing file:
    >
    > - * Tests x86 Memory Protection Keys (see Documentation/core-api/protection-keys.rst)
    > + * Tests Memory Protection Keys (see Documentation/vm/protection-keys.txt)
    >
    > It sounds to me that the changeset that introduced such change
    > 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
    > could also have other side effects, as it sounds that it was not
    > generated against uptream code, but, instead, against a version
    > older than Jun 7, 2019.
    >
    > Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
    > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

    Thanks for finding this! The patch set which moved protection-keys.txt
    out of x86 code probably just missed this when it got rebased. It
    originated well before June 2019, iirc.

    Acked-by: Dave Hansen <dave.hansen@intel.com>

    \
     
     \ /
      Last update: 2020-05-04 16:11    [W:2.146 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site