lkml.org 
[lkml]   [2020]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 51/73] RDMA/cm: Fix an error check in cm_alloc_id_priv()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 983653515849fb56b78ce55d349bb384d43030f6 upstream.

    The xa_alloc_cyclic_irq() function returns either 0 or 1 on success and
    negatives on error. This code treats 1 as an error and returns ERR_PTR(1)
    which will cause an Oops in the caller.

    Fixes: ae78ff3a0f0c ("RDMA/cm: Convert local_id_table to XArray")
    Link: https://lore.kernel.org/r/20200407093714.GA80285@mwanda
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/core/cm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/infiniband/core/cm.c
    +++ b/drivers/infiniband/core/cm.c
    @@ -836,7 +836,7 @@ struct ib_cm_id *ib_create_cm_id(struct

    ret = xa_alloc_cyclic_irq(&cm.local_id_table, &id, NULL, xa_limit_32b,
    &cm.local_id_next, GFP_KERNEL);
    - if (ret)
    + if (ret < 0)
    goto error;
    cm_id_priv->id.local_id = (__force __be32)id ^ cm.random_id_operand;
    xa_store_irq(&cm.local_id_table, cm_local_id(cm_id_priv->id.local_id),

    \
     
     \ /
      Last update: 2020-05-04 20:07    [W:5.094 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site