lkml.org 
[lkml]   [2020]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] media: exynos4-is: Fix runtime PM imbalance in isp_video_open()
From
Date
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.

How do you think about a wording variant like the following?

Change description:
The PM runtime usage counter is incremented even if a call of
the function “pm_runtime_get_sync” failed. Thus decrement it also
in an error case so that the reference counting is kept consistent.


Would you like to add the tag “Fixes” to the commit message?


Can it make sense to combine the software adjustment with the
update step “media: exynos4-is: Fix runtime PM imbalance in fimc_is_probe”?
https://lore.kernel.org/linux-arm-kernel/20200524025903.17219-1-dinghao.liu@zju.edu.cn/
https://lore.kernel.org/patchwork/patch/1246424/



+++ b/drivers/media/platform/exynos4-is/fimc-isp-video.c
@@ -293,6 +293,7 @@ static int isp_video_open(struct file *file)
if (!ret)
goto unlock;
rel_fh:
+ pm_runtime_put_noidle(&isp->pdev->dev);
v4l2_fh_release(file);
unlock:


Is there a need to use a label like “put_pm”?
Regards,
Markus

\
 
 \ /
  Last update: 2020-05-31 18:07    [W:0.025 / U:11.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site