lkml.org 
[lkml]   [2020]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error
On Tue, 26 May 2020 13:13:56 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Tue, May 26, 2020 at 12:47 PM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>
> > When devm_regmap_init_i2c() returns an error code, a pairing
> > runtime PM usage counter decrement is needed to keep the
> > counter balanced. For error paths after ak8974_set_power(),
> > ak8974_detect() and ak8974_reset(), things are the same.
> >
> > However, When iio_triggered_buffer_setup() returns an error
> > code, there will be two PM usgae counter decrements.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> > ---
> >
> > Changelog:
> >
> > v2: - Change 3 goto targets from "power_off" to
> > "disabel_pm". Remove unused lable "power_off".
> > Move 3 PM runtime related calls to the end of
> > the function.
>
> Thanks for fixing this Dinghao!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Could I have a fixes tag for this one?

Thanks,

Jonathan

>
> Yours,
> Linus Walleij

\
 
 \ /
  Last update: 2020-05-31 16:00    [W:0.068 / U:4.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site