lkml.org 
[lkml]   [2020]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] mailbox: no error log in mbox_client_txdone() for tx done by irq
On Mon, May 11, 2020 at 12:52 AM <joe_zhuchg@126.com> wrote:
>
> From: Joe Zhu <Chunguang.Zhu@verisilicon.com>
>
> client does not know and not care about how controller implement tx done.
> mbox_client_txdone() may be called when controller uses irq method.
>
> Signed-off-by: Joe Zhu <Chunguang.Zhu@verisilicon.com>
> ---
> drivers/mailbox/mailbox.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
> index 0b821a5b2db8..116124adf188 100644
> --- a/drivers/mailbox/mailbox.c
> +++ b/drivers/mailbox/mailbox.c
> @@ -189,7 +189,9 @@ EXPORT_SYMBOL_GPL(mbox_chan_txdone);
> void mbox_client_txdone(struct mbox_chan *chan, int r)
> {
> if (unlikely(!(chan->txdone_method & TXDONE_BY_ACK))) {
> - dev_err(chan->mbox->dev, "Client can't run the TX ticker\n");
> + if (unlikely(!(chan->txdone_method & TXDONE_BY_IRQ)))
> + dev_err(chan->mbox->dev,
> + "Client can't run the TX ticker\n");
> return;
> }
If it is not by ACK, client should not call txdone() so we shout
immediately. Otherwise something is wrong.

thanks.

\
 
 \ /
  Last update: 2020-05-30 22:27    [W:0.062 / U:3.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site