Messages in this thread | | | Date | Sat, 30 May 2020 11:31:52 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v2] check: Add 10bit/slave i2c reg flags support |
| |
> + addr = reg & 0x3FFFFFFFU; > + snprintf(unit_addr, sizeof(unit_addr), "%x", addr);
Hmm, this hardcoded value will not work if we ever need to add another bit. I hope this will never happen, though.
> + if ((reg & (1U << 31)) && addr > 0x3ff)
Same here with bit 31. I haven't checked DTC but can't we import the header with the defines into the project? Or is this then a circular dependency?
[unhandled content-type:application/pgp-signature]
| |