lkml.org 
[lkml]   [2020]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] spi: bcm2835: Implement shutdown callback
    On Thu, May 28, 2020 at 12:06:05PM -0700, Florian Fainelli wrote:
    > Make sure we clear the FIFOs, stop the block, disable the clock and
    > release the DMA channel.

    To what end? Why is this change necessary? Sorry but this seems like
    an awfully terse commit message.

    Thanks,

    Lukas

    >
    > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    > ---
    > drivers/spi/spi-bcm2835.c | 10 ++++++++++
    > 1 file changed, 10 insertions(+)
    >
    > diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
    > index 20d8581fdf88..237bd306c268 100644
    > --- a/drivers/spi/spi-bcm2835.c
    > +++ b/drivers/spi/spi-bcm2835.c
    > @@ -1391,6 +1391,15 @@ static int bcm2835_spi_remove(struct platform_device *pdev)
    > return 0;
    > }
    >
    > +static void bcm2835_spi_shutdown(struct platform_device *pdev)
    > +{
    > + int ret;
    > +
    > + ret = bcm2835_spi_remove(pdev);
    > + if (ret)
    > + dev_err(&pdev->dev, "failed to shutdown\n");
    > +}
    > +
    > static const struct of_device_id bcm2835_spi_match[] = {
    > { .compatible = "brcm,bcm2835-spi", },
    > {}
    > @@ -1404,6 +1413,7 @@ static struct platform_driver bcm2835_spi_driver = {
    > },
    > .probe = bcm2835_spi_probe,
    > .remove = bcm2835_spi_remove,
    > + .shutdown = bcm2835_spi_shutdown,
    > };
    > module_platform_driver(bcm2835_spi_driver);
    >
    > --
    > 2.17.1
    >

    \
     
     \ /
      Last update: 2020-05-29 19:48    [W:3.475 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site