lkml.org 
[lkml]   [2020]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 3/7] smp: Move irq_work_run() out of flush_smp_call_function_queue()
On Tue, May 26, 2020 at 06:11:00PM +0200, Peter Zijlstra wrote:
> This ensures flush_smp_call_function_queue() is strictly about
> call_single_queue.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> kernel/smp.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -84,6 +84,7 @@ int smpcfd_dying_cpu(unsigned int cpu)
> * still pending.
> */
> flush_smp_call_function_queue(false);
> + irq_work_run();
> return 0;
> }
>
> @@ -191,6 +192,14 @@ static int generic_exec_single(int cpu,
> void generic_smp_call_function_single_interrupt(void)
> {
> flush_smp_call_function_queue(true);
> +
> + /*
> + * Handle irq works queued remotely by irq_work_queue_on().
> + * Smp functions above are typically synchronous so they
> + * better run first since some other CPUs may be busy waiting
> + * for them.
> + */

You may want to update that comment once you merge remote irq_work and csd.

Thanks.

> + irq_work_run();
> }
>
> /**
> @@ -267,14 +276,6 @@ static void flush_smp_call_function_queu
> csd_unlock(csd);
> func(info);
> }
> -
> - /*
> - * Handle irq works queued remotely by irq_work_queue_on().
> - * Smp functions above are typically synchronous so they
> - * better run first since some other CPUs may be busy waiting
> - * for them.
> - */
> - irq_work_run();
> }
>
> /*
>
>

\
 
 \ /
  Last update: 2020-05-29 15:07    [W:1.056 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site