Messages in this thread | | | Date | Fri, 29 May 2020 13:11:00 +0200 | Subject | Re: [PATCH net-next] net: phy: mscc: fix PHYs using the vsc8574_probe | From | Michael Walle <> |
| |
Am 29. Mai 2020 11:49:09 MESZ schrieb Antoine Tenart <antoine.tenart@bootlin.com>: >PHYs using the vsc8574_probe fail to be initialized and their >config_init return -EIO leading to errors like: >"could not attach PHY: -5". > >This is because when the conversion of the MSCC PHY driver to use the >shared PHY package helpers was done, the base address retrieval and the >base PHY read and write helpers in the driver were modified. In >particular, the base address retrieval logic was moved from the >config_init to the probe. But the vsc8574_probe was forgotten. This >patch fixes it. > >Fixes: deb04e9c0ff2 ("net: phy: mscc: use phy_package_shared") >Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Reviewed-by: Michael Walle <michael@walle.cc>
thanks, -michael
| |