lkml.org 
[lkml]   [2020]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 09/11] dmaengine: dw: Initialize min_burst capability
On Fri, May 29, 2020 at 01:25:15PM +0300, Andy Shevchenko wrote:
> On Fri, May 29, 2020 at 01:23:59AM +0300, Serge Semin wrote:
> > According to the DW APB DMAC data book the minimum burst transaction
> > length is 1 and it's true for any version of the controller since
> > isn't parametrised in the coreAssembler so can't be changed at the
> > IP-core synthesis stage. Let's initialise the min_burst member of the
> > DMA controller descriptor so the DMA clients could use it to properly
> > optimize the DMA requests.

...

> > /* DMA capabilities */
>
> > + dw->dma.min_burst = 1;
>
> Perhaps then relaxed maximum, like
>
> dw->dma.max_burst = 256;
>
> (channels will update this)
>
> ?

And forgot to mention that perhaps we need a definitions for both.

> > dw->dma.src_addr_widths = DW_DMA_BUSWIDTHS;
> > dw->dma.dst_addr_widths = DW_DMA_BUSWIDTHS;

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-05-29 12:31    [W:0.053 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site