Messages in this thread | | | Subject | Re: [PATCH 08/30] KVM: nSVM: move map argument out of enter_svm_guest_mode | From | Krish Sadhukhan <> | Date | Fri, 29 May 2020 13:02:02 -0700 |
| |
On 5/29/20 12:04 PM, Paolo Bonzini wrote: > On 29/05/20 20:10, Krish Sadhukhan wrote: >>> Unmapping the nested VMCB in enter_svm_guest_mode is a bit of a wart, >>> since the map is not used elsewhere in the function. There are >>> just two calls, so move it there. >> The last sentence sounds bit incomplete. > Good point---more precisely, "calls" should be "callers". "It" refers > to "unmapping". > >> Also, does it make sense to mention the reason why unmapping is not >> required before we enter guest mode ? > Unmapping is a host operation and is not visible by the guest; is this > what you mean?
Yes, I was thinking if we could mention it in the commit message...
-Krish
> > Paolo >
| |