Messages in this thread | | | Subject | Re: [PATCH net-next v4 1/4] dt-bindings: net: Add tx and rx internal delays | From | Dan Murphy <> | Date | Fri, 29 May 2020 14:24:52 -0500 |
| |
Rob
On 5/29/20 1:25 PM, Rob Herring wrote: > On Wed, May 27, 2020 at 11:49:31AM -0500, Dan Murphy wrote: >> tx-internal-delays and rx-internal-delays are a common setting for RGMII >> capable devices. >> >> These properties are used when the phy-mode or phy-controller is set to >> rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the >> controller that the PHY will add the internal delay for the connection. >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> .../bindings/net/ethernet-controller.yaml | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml >> index ac471b60ed6a..70702a4ef5e8 100644 >> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml >> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml >> @@ -143,6 +143,20 @@ properties: >> Specifies the PHY management type. If auto is set and fixed-link >> is not specified, it uses MDIO for management. >> >> + rx-internal-delay-ps: >> + $ref: /schemas/types.yaml#definitions/uint32 >> + description: | >> + RGMII Receive PHY Clock Delay defined in pico seconds. This is used for >> + PHY's that have configurable RX internal delays. This property is only >> + used when the phy-mode or phy-connection-type is rgmii-id or rgmii-rxid. > Isn't this a property of the phy (this is the controller schema)? Looks > like we have similar properties already and they go in phy nodes. Would > be good to have a standard property, but let's be clear where it goes. > > We need to add '-ps' as a standard unit suffix (in dt-schema) and then a > type is not needed here.
This is a PHY specific property.
I will move them.
Dumb question but you can just point me to the manual about how and where to add the '-ps' to the dt-schema
Dan
> Rob
| |