Messages in this thread | | | Date | Thu, 28 May 2020 16:55:30 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 2/3] kasan: move kasan_report() into report.c |
| |
On Thu, May 28, 2020 at 09:33:41AM -0500, Josh Poimboeuf wrote: > On Thu, May 28, 2020 at 09:49:13AM -0400, Qian Cai wrote: > > On Tue, May 12, 2020 at 05:33:20PM +0200, 'Andrey Konovalov' via kasan-dev wrote: > > > The kasan_report() functions belongs to report.c, as it's a common > > > functions that does error reporting. > > > > > > Reported-by: Leon Romanovsky <leon@kernel.org> > > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > > > > Today's linux-next produced this with Clang 11. > > > > mm/kasan/report.o: warning: objtool: kasan_report()+0x8a: call to __stack_chk_fail() with UACCESS enabled > > > > kasan_report at mm/kasan/report.c:536 > > Peter, this was also reported with GCC about a month ago. Should we add > __stack_chk_fail() to the uaccess safe list?
It calls panic(), which I suppose is pretty safe, it kills the entire machine dead :-)
Ok.
| |