Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH v2] powerpc/wii: Fix declaration made after definition | Date | Thu, 28 May 2020 23:32:29 +1000 |
| |
Nathan Chancellor <natechancellor@gmail.com> writes: > A 0day randconfig uncovered an error with clang, trimmed for brevity: > > arch/powerpc/platforms/embedded6xx/wii.c:195:7: error: attribute > declaration must precede definition [-Werror,-Wignored-attributes] > if (!machine_is(wii)) > ^ > > The macro machine_is declares mach_##name but define_machine actually > defines mach_##name, hence the warning. > > To fix this, move define_machine after the machine_is usage. > > Fixes: 5a7ee3198dfa ("powerpc: wii: platform support") > Reported-by: kbuild test robot <lkp@intel.com> > Link: https://github.com/ClangBuiltLinux/linux/issues/989 > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > > v1 -> v2: > > * s/is_machine/machine_is/ (Nick) > > * Add Nick's reviewed-by tag.
I already picked up v1, and it's behind a merge so I don't want to rebase it. I'll live with the typo. Thanks.
cheers
| |