[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 5/5] power: vexpress: make the reset driver a module
On Wed, May 27, 2020 at 3:32 PM Rob Herring <> wrote:
> On Wed, May 27, 2020 at 5:26 AM Anders Roxell <> wrote:
> >
> > Today the vexpress power driver can only be builtin. Rework so it's
> > possible for the vexpress power driver to be a module.
> This is the same incomplete patch I did[1]. As a module, it needs to
> clean-up everything probe did like overwriting global variables.
> Rob
> [1]

Your version was actually broken because it allowed unloading the
driver again. The version that Anders sent is a bit better because it
explicitly forbids unloading by having a module_init but not module_exit
function, so as long as the .suppress_bind_attrs flag is set, this will
not crash the kernel.

It would be nice to have a .remove callback, but for the merge window
I'm happy with a patch that fixes the build regression.


 \ /
  Last update: 2020-05-28 12:30    [W:0.069 / U:5.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site