lkml.org 
[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] HID: multitouch: Remove MT_CLS_WIN_8_DUAL
From
Date


> On May 27, 2020, at 20:15, Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
>
> On Wed, May 27, 2020 at 11:24 AM Benjamin Tissoires
> <benjamin.tissoires@redhat.com> wrote:
>>
>> On Wed, May 27, 2020 at 8:19 AM Kai-Heng Feng
>> <kai.heng.feng@canonical.com> wrote:
>>>
>>>
>>>
>>>> On May 26, 2020, at 16:43, Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
>>>>
>>>> On Tue, May 26, 2020 at 10:24 AM Jiri Kosina <jikos@kernel.org> wrote:
>>>>>
>>>>> On Tue, 14 Apr 2020, Kai-Heng Feng wrote:
>>>>>
>>>>>> After commit c23e2043d5f7 ("HID: multitouch: do not filter mice nodes"),
>>>>>> MT_CLS_WIN_8 also supports mouse nodes, hence make MT_CLS_WIN_8_DUAL
>>>>>> redundant.
>>>>>>
>>>>>> Remove MT_CLS_WIN_8_DUAL accordingly.
>>>>>
>>>>> Benjamin, can I get your Ack on this one please?
>>>>
>>>> Heh, funny enough I was trying to fix
>>>> https://bugzilla.kernel.org/show_bug.cgi?id=207235 and was pondering
>>>> this one too.
>>>>
>>>> To fix #207235, I'll likely need to add a new class and quirk in
>>>> hid-multitouch. I can't really find a generic solution for now, and we
>>>> better have a local quirk for the 2 devices we currently have and
>>>> backport those to stable. However, this patch will likely conflict
>>>> (trivially), with the new quirks, so I was thinking:
>>>> - submitting my quick and dirty quirk and mark it to stable
>>>> - apply this one on top of it (this one really doesn't need to go to stable)
>>>>
>>>> How does that sound?
>>>
>>> Sounds good. I'll resend this patch once your patch lands in the tree.
>>
>> Great, thanks. Though I should be able to rebase it and push it
>> directly. I'll notify you if I can't get to it today.
>
> Alright, rebased and pushed to for-5.8/multitouch.
>
> Thanks a lot.

Thanks for your work :)

Kai-Heng

>
> Cheers,
> Benjamin
>
>>
>> Cheers,
>> Benjamin
>>
>>>
>>> Kai-Heng
>>>
>>>>
>>>> Cheers,
>>>> Benjamin
>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> --
>>>>> Jiri Kosina
>>>>> SUSE Labs

\
 
 \ /
  Last update: 2020-05-28 11:37    [W:0.045 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site