lkml.org 
[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] writeback: remove unused variable
From
Date
On 28.05.20 05:37, Chao Yu wrote:
> Commit 64081362e8ff ("mm/page-writeback.c: fix range_cyclic writeback
> vs writepages deadlock") left unused variable, remove it.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> mm/page-writeback.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index a53f4cfa7628..7e9714d2ce9d 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2160,7 +2160,6 @@ int write_cache_pages(struct address_space *mapping,
> int error;
> struct pagevec pvec;
> int nr_pages;
> - pgoff_t uninitialized_var(writeback_index);
> pgoff_t index;
> pgoff_t end; /* Inclusive */
> pgoff_t done_index;
> @@ -2169,8 +2168,7 @@ int write_cache_pages(struct address_space *mapping,
>
> pagevec_init(&pvec);
> if (wbc->range_cyclic) {
> - writeback_index = mapping->writeback_index; /* prev offset */
> - index = writeback_index;
> + index = mapping->writeback_index; /* prev offset */
> end = -1;
> } else {
> index = wbc->range_start >> PAGE_SHIFT;
>

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2020-05-28 10:36    [W:0.150 / U:2.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site