lkml.org 
[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/6] arm64: dts: qcom: add sm8150 hdk dts
    On Sat 23 May 19:38 PDT 2020, Jonathan Marek wrote:

    > Add initial HDK855 dts, based on sm8150-mtp, with a few changes.
    >

    Happy to see this on the list Jonathan, just some minor things on the
    remoteproc nodes below.

    > Signed-off-by: Jonathan Marek <jonathan@marek.ca>
    > ---
    > arch/arm64/boot/dts/qcom/Makefile | 1 +
    > arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++
    > 2 files changed, 462 insertions(+)
    > create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts
    >
    > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
    > index cc103f7020fd..e5dbd8b63951 100644
    > --- a/arch/arm64/boot/dts/qcom/Makefile
    > +++ b/arch/arm64/boot/dts/qcom/Makefile
    > @@ -22,6 +22,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
    > +dtb-$(CONFIG_ARCH_QCOM) += sm8150-hdk.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sm8150-mtp.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb
    > diff --git a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
    [..]
    > +/ {
    > + model = "Qualcomm Technologies, Inc. SM8150 HDK";
    > + compatible = "qcom,sm8150-hdk";
    > +
    > + aliases {
    > + serial0 = &uart2;
    > + };
    > +
    > + chosen {
    > + stdout-path = "serial0:115200n8";
    > + };
    > +
    > + vph_pwr: vph-pwr-regulator {
    > + compatible = "regulator-fixed";
    > + regulator-name = "vph_pwr";
    > + regulator-min-microvolt = <3700000>;
    > + regulator-max-microvolt = <3700000>;
    > + };
    > +
    > + /*
    > + * Apparently RPMh does not provide support for PM8150 S4 because it
    > + * is always-on; model it as a fixed regulator.
    > + */

    One day we should stop being surprised by this and drop the "Apparently"
    from this comment ;)

    > + vreg_s4a_1p8: pm8150-s4 {
    > + compatible = "regulator-fixed";
    > + regulator-name = "vreg_s4a_1p8";
    > +
    > + regulator-min-microvolt = <1800000>;
    > + regulator-max-microvolt = <1800000>;
    > +
    > + regulator-always-on;
    > + regulator-boot-on;
    > +
    > + vin-supply = <&vph_pwr>;
    > + };
    [..]
    > +&remoteproc_adsp {
    > + status = "okay";

    It would be nice to see a
    firmware-name = "qcom/sm8150/adsp.mbn";

    here. Because if we ever end up pushing firmware to linux-firmware this
    DTB would continue to work.

    Use https://github.com/andersson/pil-squasher to get mbn files out of
    the mdt+bXX files for your testing (or just rename/symlink the mdt to
    mbn for now).

    > +};
    > +
    > +&remoteproc_cdsp {
    > + status = "okay";

    firmware-name = "qcom/sm8150/cdsp.mbn";

    > +};
    > +
    > +&remoteproc_slpi {
    > + status = "okay";

    firmware-name = "qcom/sm8150/slpi.mbn";

    Regards,
    Bjorn

    > +};
    > +
    > +&tlmm {
    > + gpio-reserved-ranges = <0 4>, <126 4>;
    > +};
    > +
    > +&uart2 {
    > + status = "okay";
    > +};
    > +
    > +&ufs_mem_hc {
    > + status = "okay";
    > +
    > + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
    > +
    > + vcc-supply = <&vreg_l10a_2p5>;
    > + vcc-max-microamp = <750000>;
    > + vccq-supply = <&vreg_l9a_1p2>;
    > + vccq-max-microamp = <700000>;
    > + vccq2-supply = <&vreg_s4a_1p8>;
    > + vccq2-max-microamp = <750000>;
    > +};
    > +
    > +&ufs_mem_phy {
    > + status = "okay";
    > +
    > + vdda-phy-supply = <&vdda_ufs_2ln_core_1>;
    > + vdda-max-microamp = <90200>;
    > + vdda-pll-supply = <&vreg_l3c_1p2>;
    > + vdda-pll-max-microamp = <19000>;
    > +};
    > +
    > +&usb_1_hsphy {
    > + status = "okay";
    > + vdda-pll-supply = <&vdd_usb_hs_core>;
    > + vdda33-supply = <&vdda_usb_hs_3p1>;
    > + vdda18-supply = <&vdda_usb_hs_1p8>;
    > +};
    > +
    > +&usb_2_hsphy {
    > + status = "okay";
    > + vdda-pll-supply = <&vdd_usb_hs_core>;
    > + vdda33-supply = <&vdda_usb_hs_3p1>;
    > + vdda18-supply = <&vdda_usb_hs_1p8>;
    > +};
    > +
    > +&usb_1_qmpphy {
    > + status = "okay";
    > + vdda-phy-supply = <&vreg_l3c_1p2>;
    > + vdda-pll-supply = <&vdda_usb_ss_dp_core_1>;
    > +};
    > +
    > +&usb_2_qmpphy {
    > + status = "okay";
    > + vdda-phy-supply = <&vreg_l3c_1p2>;
    > + vdda-pll-supply = <&vdda_usb_ss_dp_core_1>;
    > +};
    > +
    > +&usb_1 {
    > + status = "okay";
    > +};
    > +
    > +&usb_2 {
    > + status = "okay";
    > +};
    > +
    > +&usb_1_dwc3 {
    > + dr_mode = "peripheral";
    > +};
    > +
    > +&usb_2_dwc3 {
    > + dr_mode = "host";
    > +};
    > --
    > 2.26.1
    >

    \
     
     \ /
      Last update: 2020-05-29 05:03    [W:3.598 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site