lkml.org 
[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy
On Thu, May 14, 2020 at 12:30:54PM -0500, Dan Murphy wrote:
> Add a dt binding for the TI dp83822 ethernet phy device.
>
> CC: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> .../devicetree/bindings/net/ti,dp83822.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/ti,dp83822.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> new file mode 100644
> index 000000000000..60afd43ad3b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
> +# Copyright (C) 2020 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/net/ti,dp83822.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: TI DP83822 ethernet PHY
> +
> +allOf:
> + - $ref: "ethernet-controller.yaml#"

Not an ethernet controller. Drop. (The ethernet-phy.yaml schema will be
applied based on node name).

> +
> +maintainers:
> + - Dan Murphy <dmurphy@ti.com>
> +
> +description: |
> + The DP83822 is a low-power, single-port, 10/100 Mbps Ethernet PHY. It
> + provides all of the physical layer functions needed to transmit and receive
> + data over standard, twisted-pair cables or to connect to an external,
> + fiber-optic transceiver. Additionally, the DP83822 provides flexibility to
> + connect to a MAC through a standard MII, RMII, or RGMII interface
> +
> + Specifications about the charger can be found at:
> + http://www.ti.com/lit/ds/symlink/dp83822i.pdf
> +
> +properties:
> + reg:
> + maxItems: 1
> +
> + ti,signal-polarity-low:

What signal?

> + type: boolean
> + description: |
> + DP83822 PHY in Fiber mode only.
> + Sets the DP83822 to detect a link drop condition when the signal goes
> + high. If not set then link drop will occur when the signal goes low.

The naming is not clear that low is for link drop. So maybe:

ti,link-loss-low

Rob

\
 
 \ /
  Last update: 2020-05-28 19:49    [W:0.159 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site