[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 02/18] nitro_enclaves: Define the PCI device interface

On 27/05/2020 01:21, Greg KH wrote:
> On Tue, May 26, 2020 at 08:01:36PM +0300, Paraschiv, Andra-Irina wrote:
>> On 26/05/2020 09:44, Greg KH wrote:
>>> On Tue, May 26, 2020 at 01:13:18AM +0300, Andra Paraschiv wrote:
>>>> +struct enclave_get_slot_req {
>>>> + /* Context ID (CID) for the enclave vsock device. */
>>>> + u64 enclave_cid;
>>>> +} __attribute__ ((__packed__));
>>> Can you really "pack" a single member structure?
>>> Anyway, we have better ways to specify this instead of the "raw"
>>> __attribute__ option. But first see if you really need any of these, at
>>> first glance, I do not think you do at all, and they can all be removed.
>> There are a couple of data structures with more than one member and multiple
>> field sizes. And for the ones that are not, gathered as feedback from
>> previous rounds of review that should consider adding a "flags" field in
>> there for further extensibility.
> Please do not do that in ioctls. Just create new calls instead of
> trying to "extend" existing ones. It's always much easier.
>> I can modify to have "__packed" instead of the attribute callout.
> Make sure you even need that, as I don't think you do for structures
> like the above one, right?

For the ones like the above, not, I just customized the usage of "__packed".


Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
 \ /
  Last update: 2020-05-28 18:38    [W:0.103 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site