[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: proc/fd: Remove the initialization of variables in seq_show()
>>> The variables{files, file} will definitely be assigned,
>> I find an other specification nicer for these identifiers.
>>> so we don't need to initialize them.

> We don't need to initialize the variable “file”.

I can agree to this interpretation of the software situation
because there is a precondition involved for the variable “ret”.

> I don't find the programming concerns around the handling of the null
> pointer for the variable “file”.

I find the initial change description too terse and therefore incomplete.

> If you have other suggestions, please elaborate on the details.

I propose to extend the patch.
How do you think about to convert initialisations for the variables
“f_flags” and “ret” also into later assignments?


 \ /
  Last update: 2020-05-28 18:05    [W:0.089 / U:1.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site