lkml.org 
[lkml]   [2020]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] [net-next] nexthop: fix enum type confusion
Date
Clang points out a mismatch between function arguments
using a different enum type:

net/ipv4/nexthop.c:841:30: error: implicit conversion from enumeration type 'enum nexthop_event_type' to different enumeration type 'enum fib_event_type' [-Werror,-Wenum-conversion]
call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh);
~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~

This looks like a copy-paste error, so just use the intended
type instead.

Fixes: 8590ceedb701 ("nexthop: add support for notifiers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
net/ipv4/nexthop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
index 143011f9b580..ec1282858cb7 100644
--- a/net/ipv4/nexthop.c
+++ b/net/ipv4/nexthop.c
@@ -37,7 +37,7 @@ static const struct nla_policy rtm_nh_policy[NHA_MAX + 1] = {
};

static int call_nexthop_notifiers(struct net *net,
- enum fib_event_type event_type,
+ enum nexthop_event_type event_type,
struct nexthop *nh)
{
int err;
--
2.26.2
\
 
 \ /
  Last update: 2020-05-27 15:48    [W:0.050 / U:8.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site