lkml.org 
[lkml]   [2020]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] crypto: chelsio: remove redundant premature assignment to iv
From
Date
Hi Colin,

On 5/27/2020 4:59 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable iv is being assigned twice with the same value, the first
> assignment is redundant and can be removed and instead keep the
> latter assignment of iv as it is closer to the point it is being
> used.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/crypto/chelsio/chcr_ipsec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/chelsio/chcr_ipsec.c b/drivers/crypto/chelsio/chcr_ipsec.c
> index af961dcd317b..f9ad8c93e5ff 100644
> --- a/drivers/crypto/chelsio/chcr_ipsec.c
> +++ b/drivers/crypto/chelsio/chcr_ipsec.c
> @@ -398,7 +398,6 @@ inline void *copy_esn_pktxt(struct sk_buff *skb,
> memset(pos, 0, len);
> aadiv = (struct chcr_ipsec_aadiv *)pos;
> esphdr = (struct ip_esp_hdr *)skb_transport_header(skb);
> - iv = skb_transport_header(skb) + sizeof(struct ip_esp_hdr);
> xo = xfrm_offload(skb);
>
> aadiv->spi = (esphdr->spi);

Patch looks good, thank you for correcting.



\
 
 \ /
  Last update: 2020-05-27 15:39    [W:0.034 / U:36.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site