lkml.org 
[lkml]   [2020]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu_wrap()
On Wed, May 27, 2020 at 07:50:56AM +0000, nobuhiro1.iwamatsu@toshiba.co.jp wrote:
> Hi,
>
> > -----Original Message-----
> > From: stable-owner@vger.kernel.org [mailto:stable-owner@vger.kernel.org] On Behalf Of Greg Kroah-Hartman
> > Sent: Wednesday, May 27, 2020 3:53 AM
> > To: linux-kernel@vger.kernel.org
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; stable@vger.kernel.org; Peter Zijlstra (Intel)
> > <peterz@infradead.org>; Lauro Ramos Venancio <lvenanci@redhat.com>; Linus Torvalds <torvalds@linux-foundation.org>;
> > Mike Galbraith <efault@gmx.de>; Rik van Riel <riel@redhat.com>; Thomas Gleixner <tglx@linutronix.de>;
> > lwang@redhat.com; Ingo Molnar <mingo@kernel.org>; Daniel Jordan <daniel.m.jordan@oracle.com>; Sasha Levin
> > <sashal@kernel.org>
> > Subject: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu_wrap()
> >
> > From: Peter Zijlstra <peterz@infradead.org>
> >
> > [ Upstream commit c743f0a5c50f2fcbc628526279cfa24f3dabe182 ]
> >
> > More users for for_each_cpu_wrap() have appeared. Promote the construct
> > to generic cpumask interface.
> >
> > The implementation is slightly modified to reduce arguments.
> >
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > Cc: Lauro Ramos Venancio <lvenanci@redhat.com>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Mike Galbraith <efault@gmx.de>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Rik van Riel <riel@redhat.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: lwang@redhat.com
> > Link: http://lkml.kernel.org/r/20170414122005.o35me2h5nowqkxbv@hirez.programming.kicks-ass.net
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > [dj: include only what's added to the cpumask interface, 4.4 doesn't
> > have them in the scheduler]
> > Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > ---
> > include/linux/cpumask.h | 17 +++++++++++++++++
> > lib/cpumask.c | 32 ++++++++++++++++++++++++++++++++
> > 2 files changed, 49 insertions(+)
>
> This commit also needs the following commits:
>
> commit d207af2eab3f8668b95ad02b21930481c42806fd
> Author: Michael Kelley <mhkelley@outlook.com>
> Date: Wed Feb 14 02:54:03 2018 +0000
>
> cpumask: Make for_each_cpu_wrap() available on UP as well
>
> for_each_cpu_wrap() was originally added in the #else half of a
> large "#if NR_CPUS == 1" statement, but was omitted in the #if
> half. This patch adds the missing #if half to prevent compile
> errors when NR_CPUS is 1.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Michael Kelley <mhkelley@outlook.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: kys@microsoft.com
> Cc: martin.petersen@oracle.com
> Cc: mikelley@microsoft.com
> Fixes: c743f0a5c50f ("sched/fair, cpumask: Export for_each_cpu_wrap()")
> Link: http://lkml.kernel.org/r/SN6PR1901MB2045F087F59450507D4FCC17CBF50@SN6PR1901MB2045.namprd19.prod.outlook.com
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
>
> Please apply this commit.

Good catch, now queued up, thanks.

greg k-h

\
 
 \ /
  Last update: 2020-05-27 10:10    [W:0.087 / U:5.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site