Messages in this thread | | | Date | Wed, 27 May 2020 17:50:34 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH 1/2] xen-pciback: Use dev_printk() when possible |
| |
On Wed, May 27, 2020 at 03:34:26PM -0700, Boris Ostrovsky wrote: > On 5/27/20 1:43 PM, Bjorn Helgaas wrote: > > @@ -155,8 +157,8 @@ int xen_pcibk_config_read(struct pci_dev *dev, int offset, int size, > > u32 value = 0, tmp_val; > > > > if (unlikely(verbose_request)) > > - printk(KERN_DEBUG DRV_NAME ": %s: read %d bytes at 0x%x\n", > > - pci_name(dev), size, offset); > > + dev_printk(KERN_DEBUG, &dev->dev, "read %d bytes at 0x%x\n", > > + size, offset); > > > Maybe then dev_dbg() ?
printk(KERN_DEBUG) always produces output, so I used dev_printk(KERN_DEBUG) to retain that behavior.
dev_dbg() does not always produce output, since it depends on DEBUG or CONFIG_DYNAMIC_DEBUG and the dynamic debug settings.
If dev_dbg() seems like the right thing, I would probably add a separate patch on top to convert dev_printk(KERN_DEBUG) to dev_dbg().
Thanks for taking a look!
Bjorn
| |