lkml.org 
[lkml]   [2020]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] of: Fix a refcounting bug in __of_attach_node_sysfs()
On Wed, 20 May 2020 15:04:14 +0300, Dan Carpenter wrote:
> The problem in this code is that if kobject_add() fails, then it should
> call of_node_put(np) to drop the reference count. I've actually moved
> the of_node_get(np) later in the function to avoid needing to do clean
> up.
>
> Fixes: 5b2c2f5a0ea3 ("of: overlay: add missing of_node_get() in __of_attach_node_sysfs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: move the of_node_get() instead of doing clean up. Also the v1 had a
> confusing typo in the commit message.
>
> drivers/of/kobj.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Applied, thanks!

\
 
 \ /
  Last update: 2020-05-27 20:47    [W:0.040 / U:24.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site