lkml.org 
[lkml]   [2020]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] x86: crypto: fix building crc32c with clang ias
On Wed, May 27, 2020 at 6:42 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> On Wed, May 27, 2020 at 04:17:40PM +0200, Arnd Bergmann wrote:
> > The clang integrated assembler complains about movzxw:
> >
> > arch/x86/crypto/crc32c-pcl-intel-asm_64.S:173:2: error: invalid instruction mnemonic 'movzxw'
> >
> > It seems that movzwq is the mnemonic that it expects instead,
> > and this is what objdump prints when disassembling the file.
> >
> > Fixes: 6a8ce1ef3940 ("crypto: crc32c - Optimize CRC32C calculation with PCLMULQDQ instruction")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> We had an identical patch pending from another contributor, see the
> discussion and result in the issue below.
>
> https://github.com/ClangBuiltLinux/linux/issues/1010
>
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
>

Was the other one submitted upstream? If yes, let's use that one.

Arnd

\
 
 \ /
  Last update: 2020-05-27 20:24    [W:0.074 / U:5.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site