Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Wed, 27 May 2020 19:06:26 +0200 | Subject | Re: [PATCH] irqchip/irq-mtk-sysirq: drop unnecessary spinlock |
| |
śr., 27 maj 2020 o 18:38 Marc Zyngier <maz@kernel.org> napisał(a): > > Sight... Do you realize that these two locks do not protect the same > thing at all? One protects the interrupt data, and the other protects > the MMIO register which is shared between multiple interrupts, and > on which the driver performs a RMW. > > Thanks to the removal of this spinlock, two irq_set_type() can execute > in parallel and silently corrupt the register. Not exactly an > improvement. >
Eek I missed the fact that the internal lock is tied to the chip, not the interrupt. In that case I'll convert this spinlock to a raw one.
Bart
| |