lkml.org 
[lkml]   [2020]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] KVM: x86: Initialize tdp_level during vCPU creation
From
Date
On 27/05/20 12:03, Vitaly Kuznetsov wrote:
>>
>> vcpu->arch.maxphyaddr = cpuid_query_maxphyaddr(vcpu);
>> + vcpu->arch.tdp_level = kvm_x86_ops.get_tdp_level(vcpu);
>>
>> vcpu->arch.pat = MSR_IA32_CR_PAT_DEFAULT;
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> Looking at kvm_update_cpuid() I was thinking if it would make sense to
> duplicate the "/* Note, maxphyaddr must be updated before tdp_level. */"
> comment here (it seems to be a vmx-only thing btw), drop it from
> kvm_update_cpuid() or move cpuid_query_maxphyaddr() to get_tdp_level()
> but didn't come to a conclusive answer.

Yeah, it makes sense to at least add the comment here too.

Paolo

\
 
 \ /
  Last update: 2020-05-27 18:16    [W:0.146 / U:13.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site