lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 07/18] nitro_enclaves: Init misc device providing the ioctl interface
On Tue, May 26, 2020 at 01:13:23AM +0300, Andra Paraschiv wrote:
> +#define NE "nitro_enclaves: "

Again, no need for this.

> +#define NE_DEV_NAME "nitro_enclaves"

KBUILD_MODNAME?

> +#define NE_IMAGE_LOAD_OFFSET (8 * 1024UL * 1024UL)
> +
> +static char *ne_cpus;
> +module_param(ne_cpus, charp, 0644);
> +MODULE_PARM_DESC(ne_cpus, "<cpu-list> - CPU pool used for Nitro Enclaves");

Again, please do not do this.

Can you get the other amazon.com developers on the cc: list to review
this before you send it out again? I feel like I am doing basic review
of things that should be easily caught by them before you ask the
community to review your code.

And get them to sign off on it too, showing they agree with the design
decisions here :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-05-26 08:52    [W:0.187 / U:3.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site